From ec0f78e42404e4b422103533fee885b272b7e8bd Mon Sep 17 00:00:00 2001 From: Ant Zucaro Date: Wed, 20 Jul 2011 08:59:12 -0400 Subject: [PATCH] Make sure there are at least two real players in the game before storing stats. Also make the number of real players needed easier to configure. Drop "joins" as a required attribute before allowing stats to be stored due to a bug. --- xonstat/views/submission.py | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/xonstat/views/submission.py b/xonstat/views/submission.py index 97836de..413fede 100755 --- a/xonstat/views/submission.py +++ b/xonstat/views/submission.py @@ -305,6 +305,8 @@ def create_player_stats(session=None, player=None, game=None, and 'scoreboardvalid' in player_events: pgstat = create_player_game_stat(session=session, player=player, game=game, player_events=player_events) + + #TODO: put this into a config setting in the ini file? if not re.search('^bot#\d+$', player_events['P']): create_player_weapon_stats(session=session, player=player, game=game, pgstat=pgstat, @@ -329,15 +331,18 @@ def stats_submit(request): "Can't continue.") raise Exception("Required game meta fields (T, G, M, or S) missing.") - has_real_players = False + real_players = 0 for player_events in players: if not player_events['P'].startswith('bot'): - if 'joins' in player_events and 'matches' in player_events\ + # removing 'joins' here due to bug, but it should be here + if 'matches' in player_events\ and 'scoreboardvalid' in player_events: - has_real_players = True + real_players += 1 - if not has_real_players: - raise Exception("No real players found. Stats ignored.") + #TODO: put this into a config setting in the ini file? + if real_players < 2: + raise Exception("The number of real players is below the minimum. "\ + "Stats will be ignored.") server = get_or_create_server(session=session, name=game_meta['S']) gmap = get_or_create_map(session=session, name=game_meta['M']) -- 2.39.2