From c356943808b74e474bec2e88ebc33a3cb85f3643 Mon Sep 17 00:00:00 2001 From: Thomas Debesse Date: Mon, 8 Mar 2021 14:10:22 +0100 Subject: [PATCH] radiant: build PIE linux binary on FHS installation --- radiant/CMakeLists.txt | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/radiant/CMakeLists.txt b/radiant/CMakeLists.txt index aa52ef32..3537a7dd 100644 --- a/radiant/CMakeLists.txt +++ b/radiant/CMakeLists.txt @@ -136,10 +136,18 @@ endif () # because of a mistake in the mime-type library. # Because of that it was not possible to launch such executables from # the file browser. +# # While the problem is fixed upstream, most distributions still ship # with a faulty mime-type library and may do for a long time. +# # See: https://gitlab.freedesktop.org/xdg/shared-mime-info/-/issues/11 -if ("${CMAKE_SYSTEM_NAME}" STREQUAL "Linux") +# +# It may produce such warning though at strip time: +# warning: allocated section `.dynstr' not in segment +# and produce an unusable binary, better not strip when using this hack. +# +# This hack is only wanted when NetRadiant is not installed system-wide. +if ("${CMAKE_SYSTEM_NAME}" STREQUAL "Linux" AND NOT FHS_INSTALL) target_link_libraries(${RADIANT_BASENAME} -no-pie) endif() -- 2.39.2