From bb3726a853183c5fecd5898c26d6b159c708071a Mon Sep 17 00:00:00 2001 From: Thomas Debesse Date: Fri, 5 Mar 2021 06:16:15 +0100 Subject: [PATCH] radiant/texwindow: fix crash when assigning a tag, fix #146 Fix crash when assigning a tag, fix #146 Seems to be a bug introduced by @TimePath in 0203ac024e9396ebc180d9721da40b90b7c33dc6 (Wrap more GTK) It was probably a typo, this is the change for which a revert fixes the bug: -gboolean TextureBrowser_tagMoveHelper( ui::TreeModel model, ui::TreePath path, GtkTreeIter* iter, GSList** selected ){ +gboolean TextureBrowser_tagMoveHelper( ui::TreeModel model, ui::TreePath path, GtkTreeIter iter, GSList** selected ){ The commit just re-add the pointer mark. --- radiant/texwindow.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/radiant/texwindow.cpp b/radiant/texwindow.cpp index 9870d2a0..cf37ff4f 100644 --- a/radiant/texwindow.cpp +++ b/radiant/texwindow.cpp @@ -1813,7 +1813,7 @@ ui::MenuItem TextureBrowser_constructTagsMenu( ui::Menu menu ){ return textures_menu_item; } -gboolean TextureBrowser_tagMoveHelper( ui::TreeModel model, ui::TreePath path, GtkTreeIter iter, GSList** selected ){ +gboolean TextureBrowser_tagMoveHelper( ui::TreeModel model, ui::TreePath path, GtkTreeIter* iter, GSList** selected ){ g_assert( selected != NULL ); auto rowref = gtk_tree_row_reference_new( model, path ); -- 2.39.2