From 4a093a902aba2c36a30bcef342628d432e79b2f2 Mon Sep 17 00:00:00 2001 From: Mario Date: Fri, 30 Aug 2013 20:56:16 +1000 Subject: [PATCH] Remove a useless global check --- qcsrc/common/monsters/spawn.qc | 7 ++----- qcsrc/common/monsters/sv_monsters.qc | 8 +++----- qcsrc/common/monsters/sv_monsters.qh | 1 - 3 files changed, 5 insertions(+), 11 deletions(-) diff --git a/qcsrc/common/monsters/spawn.qc b/qcsrc/common/monsters/spawn.qc index 95e0261ae..e8dfdd58f 100644 --- a/qcsrc/common/monsters/spawn.qc +++ b/qcsrc/common/monsters/spawn.qc @@ -1,10 +1,7 @@ entity spawnmonster (string monster, float mnster, entity spawnedby, entity own, vector orig, float respwn, float moveflag) { - if(!spawncode_first_load) - { - initialize_field_db(); - spawncode_first_load = TRUE; - } + // ensure spawnfunc database is initialized + initialize_field_db(); entity e = spawn(); diff --git a/qcsrc/common/monsters/sv_monsters.qc b/qcsrc/common/monsters/sv_monsters.qc index ff18c1add..df30e5346 100644 --- a/qcsrc/common/monsters/sv_monsters.qc +++ b/qcsrc/common/monsters/sv_monsters.qc @@ -281,7 +281,7 @@ void Monster_Fade () self.takedamage = DAMAGE_NO; setorigin(self, self.pos1); self.angles = self.pos2; - self.health = self.max_health; // TODO: check if resetting to max_health is wise here + self.health = self.max_health; self.SendFlags |= MSF_MOVE; self.SendFlags |= MSF_STATUS; @@ -863,12 +863,10 @@ void monsters_damage (entity inflictor, entity attacker, float damage, float dea } if(self.health <= 0) - { + { + // Update one more time to avoid waypoint fading without emptying healthbar if(self.sprite) - { - // Update one more time to avoid waypoint fading without emptying healthbar WaypointSprite_UpdateHealth(self.sprite, 0); - } if(deathtype == DEATH_KILL) self.candrop = FALSE; // killed by mobkill command diff --git a/qcsrc/common/monsters/sv_monsters.qh b/qcsrc/common/monsters/sv_monsters.qh index 0ceb95852..f27ce0072 100644 --- a/qcsrc/common/monsters/sv_monsters.qh +++ b/qcsrc/common/monsters/sv_monsters.qh @@ -2,7 +2,6 @@ .float monster_attack; float monster_skill; -float spawncode_first_load; // used to tell the player the monster database is loading (TODO: fix this?) .entity monster_owner; // new monster owner entity, fixes non-solid monsters .float monstercount; // per player monster count -- 2.39.2