From 048c2048e7e64bc0d0f51e60c42064161f626b1c Mon Sep 17 00:00:00 2001
From: Ant Zucaro <azucaro@gmail.com>
Date: Tue, 24 May 2011 22:43:47 -0400
Subject: [PATCH] Remove redundant code for scoreboard display, add proper
 percentages to the accuracy page.

---
 xonstat/templates/game_index.mako          | 132 +--------------------
 xonstat/templates/game_info.mako           |  65 +---------
 xonstat/templates/player_weapon_stats.mako |   3 +-
 xonstat/templates/scoreboard.mako          |   2 +-
 4 files changed, 8 insertions(+), 194 deletions(-)

diff --git a/xonstat/templates/game_index.mako b/xonstat/templates/game_index.mako
index e19a2fb..1563872 100755
--- a/xonstat/templates/game_index.mako
+++ b/xonstat/templates/game_index.mako
@@ -1,4 +1,5 @@
 <%inherit file="base.mako"/>
+<%namespace file="scoreboard.mako" import="scoreboard" />
 
 <%block name="title">
 Game Index - ${parent.title()}
@@ -12,137 +13,10 @@ Game Index - ${parent.title()}
 % for (game, server, map) in games:
 <p>
    <a href="${request.route_url("map_info", id=map.map_id)}" name="Map info page for ${map.name}">${map.name}</a> on <a href="${request.route_url("server_info", id=server.server_id)}" name="Server info page for ${server.name}">${server.name}</a> (<a href="${request.route_url('game_info', id=game.game_id)}" name="Permalink for game #${game.game_id}">permalink</a> for this game)
-<table border="1" cellpadding="3">
 
-############################ CTF Game ############################
-% if game.game_type_cd == 'ctf':
-    <tr>
-        <td>Nick</td>
-        <td>Team</td>
-        <td>Kills</td>
-        <td>Captures</td>
-        <td>Pickups</td>
-        <td>Flag Carrier Kills</td>
-        <td>Returns</td>
-        <td>Score</td>
-        <td>Accuracy</td>
-    </tr>
+## show scoreboard using a def from another file
+${scoreboard(game.game_type_cd, pgstats[game.game_id])}
 
-% for pgstat in pgstats[game.game_id]:
-    <tr>
-        <td>
-        % if pgstat.player_id > 2:
-          <a href="${request.route_url("player_info", id=pgstat.player_id)}"
-           title="Go to the info page for this player">
-          ${pgstat.nick_html_colors()}
-          </a>
-        % else:
-          ${pgstat.nick_html_colors()}
-        % endif
-        </td>
-        <td style="background-color:${pgstat.team_html_color()};"></td>
-        <td>${pgstat.kills}</td>
-        <td>${pgstat.captures}</td>
-        <td>${pgstat.pickups}</td>
-        <td>${pgstat.carrier_frags}</td>
-        <td>${pgstat.returns}</td>
-        <td>${pgstat.score}</td>
-        <td>
-        % if pgstat.player_id > 1:
-          <a href="${request.route_url("player_weapon_stats", game_id=pgstat.game_id, pgstat_id=pgstat.player_game_stat_id)}"
-           title="View weapon accuracy details for this player in this game">
-          View
-          </a>
-        % endif
-        </td>
-    </tr>
-% endfor
-% endif
-
-
-############################ DM Game ############################
-% if game.game_type_cd == 'dm':
-    <tr>
-        <td>Nick</td>
-        <td>Kills</td>
-        <td>Deaths</td>
-        <td>Suicides</td>
-        <td>Score</td>
-        <td>Accuracy</td>
-    </tr>
-
-% for pgstat in pgstats[game.game_id]:
-    <tr>
-        <td>
-        % if pgstat.player_id > 2:
-          <a href="${request.route_url("player_info", id=pgstat.player_id)}"
-           title="Go to the info page for this player">
-          ${pgstat.nick_html_colors()}
-          </a>
-        % else:
-          ${pgstat.nick_html_colors()}
-        % endif
-        </td>
-        <td>${pgstat.kills}</td>
-        <td>${pgstat.deaths}</td>
-        <td>${pgstat.suicides}</td>
-        <td>${pgstat.score}</td>
-        <td>
-        % if pgstat.player_id > 1:
-          <a href="${request.route_url("player_weapon_stats", game_id=pgstat.game_id, pgstat_id=pgstat.player_game_stat_id)}"
-           title="View weapon accuracy details for this player in this game">
-          View
-          </a>
-        % endif
-        </td>
-    </tr>
-% endfor
-% endif
-
-
-############################ TDM Game ############################
-% if game.game_type_cd == 'tdm':
-    <tr>
-        <td>Nick</td>
-        <td>Team</td>
-        <td>Kills</td>
-        <td>Deaths</td>
-        <td>Suicides</td>
-        <td>Score</td>
-        <td>Accuracy</td>
-    </tr>
-
-% for pgstat in pgstats[game.game_id]:
-    <tr>
-        <td>
-        % if pgstat.player_id > 2:
-          <a href="${request.route_url("player_info", id=pgstat.player_id)}"
-           title="Go to the info page for this player">
-          ${pgstat.nick_html_colors()}
-          </a>
-        % else:
-          ${pgstat.nick_html_colors()}
-        % endif
-        </td>
-        <td style="background-color:${pgstat.team_html_color()};"></td>
-        <td>${pgstat.kills}</td>
-        <td>${pgstat.deaths}</td>
-        <td>${pgstat.suicides}</td>
-        <td>${pgstat.score}</td>
-        <td>
-        % if pgstat.player_id > 1:
-          <a href="${request.route_url("player_weapon_stats", game_id=pgstat.game_id, pgstat_id=pgstat.player_game_stat_id)}"
-           title="View weapon accuracy details for this player in this game">
-          View
-          </a>
-        % endif
-        </td>
-    </tr>
-% endfor
-% endif
-
-############################ End gametype specific stuff ############################
-</table>
 % endfor
 % endif
 
diff --git a/xonstat/templates/game_info.mako b/xonstat/templates/game_info.mako
index 1c7d580..b479645 100644
--- a/xonstat/templates/game_info.mako
+++ b/xonstat/templates/game_info.mako
@@ -1,4 +1,5 @@
 <%inherit file="base.mako"/>
+<%namespace file="scoreboard.mako" import="scoreboard" />
 
 <%block name="title">
 Game Information - ${parent.title()}
@@ -18,67 +19,5 @@ Map: <a href="${request.route_url("map_info", id=map_id)}" name="Map info page f
 </p>
 
 <h2>Scoreboard</h2>
-<table border="1" cellpadding="3">
-% if game_type_cd == 'ctf':
-    <tr>
-        <td>Nick</td>
-        <td>Kills</td>
-        <td>Captures</td>
-        <td>Pickups</td>
-        <td>Flag Carrier Kills</td>
-        <td>Returns</td>
-        <td>Score</td>
-        <td>Accuracy</td>
-    </tr>
-
-% for player_game_stat in player_game_stats:
-    <tr>
-        <td>
-        % if player_game_stat.player_id > 2:
-          <a href="${request.route_url("player_info", id=player_game_stat.player_id)}"
-           title="Go to the info page for this player">
-          ${player_game_stat.nick_html_colors()}
-          </a>
-        % else:
-          ${player_game_stat.nick_html_colors()}
-        % endif
-        </td>
-        <td>${player_game_stat.kills}</td>
-        <td>${player_game_stat.captures}</td>
-        <td>${player_game_stat.pickups}</td>
-        <td>${player_game_stat.carrier_frags}</td>
-        <td>${player_game_stat.returns}</td>
-        <td>${player_game_stat.score}</td>
-        <td>
-        % if player_game_stat.player_id > 1:
-          <a href="${request.route_url("player_weapon_stats", game_id=player_game_stat.game_id, pgstat_id=player_game_stat.player_game_stat_id)}"
-           title="View weapon accuracy details for this player in this game">
-          View
-          </a>
-        % endif
-        </td>
-    </tr>
-% endfor
-% endif
-
-% if game_type_cd == 'dm':
-    <tr>
-        <td>Nick</td>
-        <td>Kills</td>
-        <td>Deaths</td>
-        <td>Suicides</td>
-        <td>Score</td>
-    </tr>
-
-% for player_game_stat in player_game_stats:
-    <tr>
-        <td>${player_game_stat.nick_html_colors()}</td>
-        <td>${player_game_stat.kills}</td>
-        <td>${player_game_stat.deaths}</td>
-        <td>${player_game_stat.suicides}</td>
-        <td>${player_game_stat.score}</td>
-    </tr>
-% endfor
-% endif
-</table>
+${scoreboard(game_type_cd, player_game_stats)}
 % endif
diff --git a/xonstat/templates/player_weapon_stats.mako b/xonstat/templates/player_weapon_stats.mako
index ced0a4a..84c115d 100644
--- a/xonstat/templates/player_weapon_stats.mako
+++ b/xonstat/templates/player_weapon_stats.mako
@@ -28,9 +28,10 @@ Accuracy Information - ${parent.title()}
         <td>${weapon.descr}</td>
         <td>${pwstat.fired}</td>
         <td>${pwstat.hit}</td>
-        <td>${pwstat.hit/pwstat.fired}</td>
+        <td>${round(float(pwstat.hit)/pwstat.fired*100, 2)}%</td>
         <td>${pwstat.max}</td>
         <td>${pwstat.actual}</td>
+        <td>${round(float(pwstat.actual)/pwstat.max*100, 2)}%</td>
         <td>${pwstat.frags}</td>
     </tr>
 % endfor
diff --git a/xonstat/templates/scoreboard.mako b/xonstat/templates/scoreboard.mako
index a9d2391..3b5518e 100644
--- a/xonstat/templates/scoreboard.mako
+++ b/xonstat/templates/scoreboard.mako
@@ -47,7 +47,7 @@
 % endif
 
 ##### DM #####
-% if game.game_type_cd == 'dm':
+% if game_type_cd == 'dm':
     <tr>
         <td>Nick</td>
         <td>Kills</td>
-- 
2.39.2