Rework handling of stuck entities in engine movetypes

Avoids most false positives and unnecessary work.
Mentions likely code path and cvar deprecations.

Fixes nades ending up where they shouldn't, which looked like:
Unstuck entity 450 (classname "ogre_grenade") with offset 0.000000 0.000000 28.000000.

Allows certain entities to move while stuck in the world (see comments).
Fixes https://github.com/DarkPlacesEngine/darkplaces/issues/18

Signed-off-by: bones_was_here <bones_was_here@xonotic.au>

Add missing DP_QC_FINDCHAIN_TOFIELD declarations to CSQC defs

Fix mod_q1bsp_zero_hullsize_cutoff only applying to HLBSP in some cases

In 0dfd32e1e2bb2c1bd5e58b3202271c391be423de in one code path this
applied to Q1BSP and HLBSP, but the other code path was slightly
different and there it only applied to HLBSP.  Oops :)

Signed-off-by: bones_was_here <bones_was_here@xonotic.au>

Improve server lag detection and reporting

On a dedicated server, significant lag is reported to players (so they
know it wasn't the network or their machine).

Cvar sv_lagreporting_strict logs even slight lag that was "recovered" to
console.

sv_lagreporting_always enables these for empty servers or singleplayer.

Signed-off-by: bones_was_here <bones_was_here@xonotic.au>

Deduct frame execution time from sleep time

Fixes failure to sustain cl_maxfps/sys_ticrate when the system can
exceed it if unlimited, should improve frame pacing too.

Includes related refactoring. Actually this commit is mostly refactoring.

Signed-off-by: bones_was_here <bones_was_here@xonotic.au>

Properly reset server timers and perf stats after level change

This prevents the server running "catchup" physics frames immediately
after level change (when sv_maxphysicsframesperserverframe > 1) and
makes accurate stats available almost immediately (all 0 before that).

Moves perf stats from persistent to temporary storage.

Signed-off-by: bones_was_here <bones_was_here@xonotic.au>

Fix host.framecount

It never incremented if sleep was called, and could have eventually
become negative.

Signed-off-by: bones_was_here <bones_was_here@xonotic.au>

curl: use much less conservative performance defaults

Matches defaults used in Xonotic >= 0.8.2

Dedicated server throughput is still limited by ticrate to avoid a
reduction in frame pacing precision, see 025fbac31da7f654e296e20b3037b5ce88074f8b

Signed-off-by: bones_was_here <bones_was_here@xonotic.au>

Fix flags and naming of cvars needed by the dedicated server

The cl_curl* cvars also apply to the dedicated server so not
registering them in 3a58ad52e63635c93e95955f984fd6052156e56b broke HTTP.
These now have aliases for backwards compat (eg Xonotic, Nexuiz menus).

cl_maxphysicsframesperserverframe is server-specific and was also used
by the dedicated server for "catch up" if it got behind.

Signed-off-by: bones_was_here <bones_was_here@xonotic.au>

strcat(): update QC defs to match implementation

Xonotic was defining strcat1n to allow single-arg cases without
boilerplate...

Signed-off-by: bones_was_here <bones_was_here@xonotic.au>

checkextension(): check libcurl is loaded before returning it's available

Signed-off-by: bones_was_here <bones_was_here@xonotic.au>

Fix flags and naming of Q3BSP curve collision cvars, related tidying

r_subdivisions_collision* were marked as client-only, so not registering
them in the dedicated server in 3a58ad52e63635c93e95955f984fd6052156e56b
broke Q3BSP curve collisions.  Renamed to mod_q3bsp_curves_subdivisions*
for consistency.

Removed 3 obsolete mod_q3bsp cvars, moved r_fxaa to gl_rmain.c

Signed-off-by: bones_was_here <bones_was_here@xonotic.au>

Add some missing csprogs defs

Signed-off-by: bones_was_here <bones_was_here@xonotic.au>

mod() builtin: match gmqcc and fteqw

Also catch div0, he escaped again

Signed-off-by: bones_was_here <bones_was_here@xonotic.au>

Add cvar mod_q1bsp_zero_hullsize_cutoff for games using "big" projectiles on Q1BSP

Signed-off-by: bones_was_here <bones_was_here@xonotic.au>

Merge MR 'Fix inability to access non-ascii path under Windows with WTF-8'

See https://gitlab.com/xonotic/darkplaces/-/merge_requests/142

Signed-off-by: bones_was_here <bones_was_here@xonotic.au>

dedicated server: don't call CL_UpdateScreen() and SCR_BeginLoadingPlaque()

dedicated server: don't register client-only cvars

Fixes random client cvars like r_trippy and cl_netpacketloss_send
appearing in the server.

Adds a warn (instead of crashing) for if we try to set an unregistered
engine cvar somewhere.

mod_bsp_portalize: remove from dedicated server, update description

sv_cullentities_portal was removed in
d3b158411b1d81181e05f750d9a7b0b2268438e2 so the server has no use for it
now.

Merge MR 'Implement DP_QC_NUDGEOUTOFSOLID extension, fix Quake item bugs' into 'master'

See merge request https://gitlab.com/xonotic/darkplaces/-/merge_requests/144

Signed-off-by: bones_was_here <bones_was_here@xonotic.au>

Use qbool for some trace_s members, other tidying

Signed-off-by: bones_was_here <bones_was_here@xonotic.au>

Implement DP_QC_NUDGEOUTOFSOLID extension

Signed-off-by: bones_was_here <bones_was_here@xonotic.au>

Q1BSP: Fix TraceBox failing to move a bbox out of solid

Fixes https://github.com/DarkPlacesEngine/darkplaces/issues/85

Signed-off-by: bones_was_here <bones_was_here@xonotic.au>

droptofloor(): refactor and use correct conditions for each BSP format

Behaviour changes:

Although startsolid is used by Q3 and Q2, it's too strict for Quake
which used allsolid, so we now use the correct conditions for each BSP
format.

The downtrace endpoint is now calculated after
sv_gameplayfix_droptofloorstartsolid_nudgetocorrect.

The downtrace endpoint is now offset when using the
sv_gameplayfix_droptofloorstartsolid fallback path, otherwise it would
trace a diagonal line for entities whose origin is not horizontally centred
in their bbox.

Signed-off-by: bones_was_here <bones_was_here@xonotic.au>

droptofloor(): fix collisions between entities, including on id1 maps

The presence of a monster bbox shouldn't cause a health to be considered
"in solid".

Signed-off-by: bones_was_here <bones_was_here@xonotic.au>

Add prefix to VM_Warning indicating which VM it came from

A few messages include this but many don't, and in future there will be
less functions with SV or CL in their name.

Signed-off-by: bones_was_here <bones_was_here@xonotic.au>

droptofloor(): add/improve warnings for badly placed entities

In the past, sv_gameplayfix_droptofloorstartsolid and
sv_gameplayfix_droptofloorstartsolid_nudgetocorrect were enabled by
default when playing Quake, which seems to have led to some maps
depending on them.

These need to be off by default in Quake to avoid gameplay changes,
but we can at least warn people about map entity issues.

See: 34e819a626f6a7ff2ad190a8e7d42e38ca8cef0e

Signed-off-by: bones_was_here <bones_was_here@xonotic.au>

NudgeOutOfSolid: fix "random" failures on slightly inclined planes

History:
This epsilon value was first added to the nudge distance in
31e7715cffcebfd400b8473f3b2d3dc80937fc5a
and was replaced with bbox expansion in
25c09ca585e81bf9eb236a339ae5dcd64f63b679

With the expansion approach we need to compare to separation to make
"good location" detection reliable, partly to avoid float precision
problems, partly to avoid compatibility problems with normal TraceBox.
For example: we drop an entity to floor successfully with TraceBox, but
then NudgeOutOfSolid decides it's in solid.

Also updated the startsolid conditions to suit the 2-pass approach.

Signed-off-by: bones_was_here <bones_was_here@xonotic.au>

NudgeOutOfSolid: add a wasn't-stuck result

It can be handy for calling code to know if the entity was initially
stuck (mainly for warnings).

Signed-off-by: bones_was_here <bones_was_here@xonotic.au>

Move SV_NudgeOutOfSolid() into a common namespace and unit

Signed-off-by: bones_was_here <bones_was_here@xonotic.au>

(wtf8) wrap 4-bytes-sequence detection in ifdef U32

Signed-off-by: NaitLee <naitli@foxmail.com>

rename and add comments for wtf8 macro flags

Signed-off-by: NaitLee <naitli@foxmail.com>

use tabs for wtf8 code indent

Signed-off-by: NaitLee <naitli@foxmail.com>

(non-ascii path) fix an Win32 API annotation, fix "mygames" folder

Signed-off-by: NaitLee <naitli@foxmail.com>

Fix inability to access non-ascii path under Windows with WTF-8

Signed-off-by: NaitLee <naitli@foxmail.com>

Disambiguate WriteDest warning

Signed-off-by: bones_was_here <bones_was_here@xonotic.au>

Clarify behaviour of random() builtin

Declare DP_QC_WHICHPACK in menudefs.qc and csprogsdefs.qc

It was only declared in dpextensions.qc

README.md: add badge for #darkplaces:matrix.org chat link

Signed-off-by: bones_was_here <bones_was_here@xonotic.au>

Improve x86 detection to fix compiler errors on other architectures

Also some related minor makefile cleanup.

Closes https://gitlab.com/xonotic/darkplaces/-/issues/382

See also: 1244b3ab0853e8738c8f5e5b617e8d8f25d4eca4

Signed-off-by: bones_was_here <bones_was_here@xonotic.au>

Merge branch 'kiwixz/macos_compile' into 'master'

Fix compilation on macOS

See merge request xonotic/darkplaces!140

Fixes https://github.com/DarkPlacesEngine/darkplaces/issues/79

Fix compilation on macOS

It has been broken since 2a97ec851bd607510e33148335fc61d51e7138cf.

Signed-off-by: kiwixz <kiwixz@outlook.com>

Update compiler options, fixing obscure bug

Added -mno-avx to avoid QC bugs on (at least) haswell and skylake targets.

Removed -fno-signaling-nans as clang doesn't support it and spams warns,
and in GCC it's the default.

Removed -fno-rounding-math as this is also the default.

fs: Use unsigned short for filename size

Also remove namesize < 0 check as this is no longer possible

fs: Use unsigned short for extra field and file comment lengths

Fix DP_QC_FINDCHAIN_TOFIELD errors

Signed-off-by: bones_was_here <bones_was_here@xonotic.au>

Implement extension DP_QC_FINDBOX

Returns a chain of entities that are touching a box (a simpler findradius);
supports DP_QC_FINDCHAIN_TOFIELD

Implements https://gitlab.com/xonotic/darkplaces/-/issues/373

Signed-off-by: bones_was_here <bones_was_here@xonotic.au>

Fix COLLISIONPARANOID build errors and warns

Signed-off-by: bones_was_here <bones_was_here@xonotic.au>

Add cvars that disable linking of SOLID_NOT entities: [cl|sv]_areagrid_link_SOLID_NOT

This also removes the partial solution added in b1d6f1dfb96bedba50fbe394ca3f0c710f99381b https://gitlab.com/xonotic/darkplaces/-/merge_requests/78

Signed-off-by: bones_was_here <bones_was_here@xonotic.au>

Optimise bindable unicode codepoint range

This improves FPS on (specifically) the Xonotic key bindings menu
screen.

Signed-off-by: bones_was_here <bones_was_here@xonotic.au>

Merge PR 'Fixed two keyboard bugs'

See https://github.com/DarkPlacesEngine/darkplaces/pull/68

Commits:
5ca6703d5f57ebe18c1fc1a97c646ba468c49442
871cfdae9e48274eacb720e2423b9d8b3818bee9

Fixes https://gitlab.com/xonotic/darkplaces/-/issues/46
Fixes https://gitlab.com/xonotic/darkplaces/-/issues/51
Fixes https://gitlab.com/xonotic/darkplaces/-/issues/60
Fixes https://gitlab.com/xonotic/darkplaces/-/issues/147

Signed-off-by: bones_was_here <bones_was_here@xonotic.au>

Add cvar sv_legacy_bbox_expand for disabling Quake entity bbox expansion

This avoids obscure bugs and awkward workarounds especially with CSQC player prediction.

Signed-off-by: bones_was_here <bones_was_here@xonotic.au>

Fix GCC 12 warns: comparison will always evaluate as true

Fixes https://github.com/DarkPlacesEngine/darkplaces/issues/55

Signed-off-by: bones_was_here <bones_was_here@xonotic.au>

Simplify VID_SetMouse() calling logic

Signed-off-by: bones_was_here <bones_was_here@xonotic.au>

refine edge cases handling to keynums/keystrings,
use the new constant `TINYSTR_LEN` in place of `sizeof(tinystr)` leftovers

Signed-off-by: NaitLee <naitli@foxmail.com>

Fixed two keyboard bugs:
Fixed inability to bind non-ascii keys;
Fixed only the first character being input when using an Input Method

Signed-off-by: NaitLee <naitli@foxmail.com>

Release the mouse during loading screen

Signed-off-by: kiwixz <kiwixz@outlook.com>

Merge MR 'Reinstate the ability to override engine commands with QC commands'

See https://gitlab.com/xonotic/darkplaces/-/merge_requests/136

Fixes https://github.com/DarkPlacesEngine/darkplaces/issues/64

Signed-off-by: bones_was_here <bones_was_here@xonotic.au>

Combine NetConn_UpdateSockets_Client() and NetConn_cl_netport_Callback()

These blocks must run together to avoid bug https://gitlab.com/xonotic/darkplaces/-/issues/376
Also, after a057e4757b55a90cbcdc287b3fdf54ccc2682315 the only
NetConn_UpdateSockets_Client() call site was in NetConn_cl_netport_Callback().

Signed-off-by: bones_was_here <bones_was_here@xonotic.au>

Remove the Xonotic +showscores kludge

Fixes https://github.com/DarkPlacesEngine/darkplaces/issues/64

See also: https://gitlab.com/xonotic/xonotic-data.pk3dir/-/merge_requests/1128
and 3912e78a6047f2c45b3ff4967df7a68ad4e1b994

Signed-off-by: bones_was_here <bones_was_here@xonotic.au>

Reimplement the ability to override engine commands with QC commands

This was working in div0-stable and was removed in 46acef5491629d06eddb8e78ed01e50b175d2bd8

Due to previous improvements by LH & Cloudwalk, the behaviour is now better:
the new QC command appears in the console in addition to the engine one,
the new command takes priority and what's going on is clearer.
When the CSQC VM shuts down, the registered command is removed.

Also this time we can has documentation.

Signed-off-by: bones_was_here <bones_was_here@xonotic.au>

Keep sockets opened after first disconnect

Signed-off-by: kiwixz <kiwixz@outlook.com>

Improve client/listen curl transfer speed at low FPS

This is a huge boost for some libcurl versions, eg 7.74 in Debian 11

Fixes https://gitlab.com/xonotic/darkplaces/-/issues/375

Signed-off-by: bones_was_here <bones_was_here@xonotic.au>

Add cvar scr_conheight and make loading progress visible under fullscreen console

Also updates related cvar descriptions and increases default
scr_loadingscreen_maxfps to 20, 10 just looked too janky.

Signed-off-by: bones_was_here <bones_was_here@xonotic.au>

Merge MR 'Refactor loading screen and fix it'

See https://gitlab.com/xonotic/darkplaces/-/merge_requests/135

Signed-off-by: bones_was_here <bones_was_here@xonotic.au>

Refactor loading screen and fix it

Signed-off-by: kiwixz <kiwixz@outlook.com>

Use correct droptofloor distance for each Quake map format

Signed-off-by: bones_was_here <bones_was_here@xonotic.au>

Remove code duplication in messagemodes and commandmode

Signed-off-by: bones_was_here <bones_was_here@xonotic.au>

Disable messagemode and messagemode2 during demo playback

Signed-off-by: bones_was_here <bones_was_here@xonotic.au>

Unload dlcache packs when changing map or disconnecting

Prevents content from the previous server and/or map from interfering with the next

Signed-off-by: bones_was_here <bones_was_here@xonotic.au>

Minor sv_cullentities refactoring

Improve reliability and documentation of portal camera eyes

Not all traces will succeed so we need to add the eye if a trace
succeeded within some recent time period, instead of only adding it when
a trace succeeded in the current frame.

Fixes https://gitlab.com/xonotic/darkplaces/-/issues/207
Fixes https://gitlab.com/xonotic/xonotic-data.pk3dir/-/issues/1596

Merge MR 'Adding the natural curve mouse acceleration'
https://gitlab.com/xonotic/darkplaces/-/merge_requests/122

branch 'natural_acceleration'

Signed-off-by: bones_was_here <bones_was_here@xonotic.au>

Adding the natural curve mouse acceleration

Signed-off-by: Draena <franparpe@disroot.org>

README.md: add links to CREDITS.md and CONTRIBUTING.md

Signed-off-by: bones_was_here <bones_was_here@xonotic.au>

Fix DEBUGGL warns & checking logic in R_Mesh_CreateFramebufferObject

Signed-off-by: bones_was_here <bones_was_here@xa.org.au>

Improve DEBUGGL

glGetError() must be called in a loop to retrieve and reset
multiple error flags.

Signed-off-by: bones_was_here <bones_was_here@xa.org.au>

glquake.h: fix wrapper #ifndef

Signed-off-by: bones_was_here <bones_was_here@xa.org.au>

Fix GCC 11 warns: r_shadow.c misleading indentation, also remove duplicated code

Signed-off-by: bones_was_here <bones_was_here@xa.org.au>

Fix GCC 11 warns: use uninitialized in R_CanSeeBox

Introduced in 8ab339588b127e88e27bfa08f6eccbf9400b51f9

Signed-off-by: bones_was_here <bones_was_here@xa.org.au>

Fix GCC 11 warns: Mod_INTERQUAKEMODEL_Load misleading indentation

Signed-off-by: bones_was_here <bones_was_here@xa.org.au>

Fix GCC 11 warns: Con_Shutdown misleading indentation

Signed-off-by: bones_was_here <bones_was_here@xa.org.au>

Fix GCC 11 warns: Matrix4x4_FromArrayFloatGL overread

Signed-off-by: bones_was_here <bones_was_here@xa.org.au>

Fix GCC 11 warns: Matrix4x4_ToArray12FloatGL overflow

Signed-off-by: bones_was_here <bones_was_here@xa.org.au>

Fix GCC 11 warns: Matrix4x4_FromArrayDoubleD3D overread

Signed-off-by: bones_was_here <bones_was_here@xa.org.au>

Fix GCC 11 warns: mismatched prototype args

Signed-off-by: bones_was_here <bones_was_here@xa.org.au>

Check macOS version < 12 to use old function name

Fixes building on macOS < 12

Optimize VectorNormalize macros by not doing the sqrt on 0 length, this also means it should be more friendly to the CPU intrinsics for 1/sqrt in a single instruction

Resolved .gitignore conflict

Update SDL2.nuget package to 2.0.22, add some more things to .gitignore.

Added convex.[ch] to compute brush shapes from point clouds for use in experimental visibility code I'm tinkering with

Add CONTRIBUTING.md for contributing guidelines

Signed-off-by: Cloudwalk <cloudwalk@icculus.org>

Merge PR 'Curl improvements'

Curl versions older than 7.57.0 (found on Debian Stretch and older) do
not implicitly initialize openssl, which leads https requests to fail.

In the course of debugging this issue verbose curl requests were needed,
so that has also been added as a cvar.

https://github.com/DarkPlacesEngine/darkplaces/pull/36

commits: ceaa16c78a1f43165206566d4f9c872664f7e680
1a711173535d4b5f4364b66177745aab165330d8

Signed-off-by: bones_was_here <bones_was_here@xa.org.au>

Merge PR 'Add a third masterextra and default it to dpm.dpmaster.org'

dpm.dpmaster.org has been serving as a xonotic master (as
dpm4.xonotic.xyz and dpm6.xonotic.xyz) for three months now, and I offer
it here in hopes it's of use.

https://github.com/DarkPlacesEngine/darkplaces/pull/33

commits: 8289ce6a72d06635b6667d7e6e80ee0890ea7c09

Signed-off-by: bones_was_here <bones_was_here@xa.org.au>

Explicitly initialize openssl for older curl versions

Signed-off-by: Gary Moon <gary@garymoon.net>

Adding developer_curl to print verbose curl output

Signed-off-by: Gary Moon <gary@garymoon.net>

Add a third masterextra and default it to dpm.dpmaster.org

dpm.dpmaster.org has been serving as a xonotic master (as
dpm4.xonotic.xyz and dpm6.xonotic.xyz) for three months now, and I offer
it here in hopes it's of use.

Signed-off-by: Gary Moon <gary@garymoon.net>

Add cvar snd_cdautopause: optional CD track pause during game pause

Previously it was mandatory and if not desired, had to be hacked around
with stuffcmd.

Also fixes:
- the CD track always being resumed when resuming from game pause,
even when muted, Ref: CDAudio_SetVolume()
- bgmvolume < 0 not pausing the CD track

Signed-off-by: bones_was_here <bones_was_here@xa.org.au>

Start render module CL_MeshEntities immediately prior to Models

Fixes https://gitlab.com/xonotic/darkplaces/-/issues/366

Starting CL_MeshEntities any later can cause the bug during r_restart.

ca03733fba98709e25d9a02882ac947f4144af6a effectively added dependency
of the Models module on the CL_MeshEntities module,
at least in certain situations where starting the Models module
results in calls to Draw_CachePic() and DrawQ_*()
which trigger the bug when they call Mod_Mesh_GetTexture().

Signed-off-by: bones_was_here <bones_was_here@xa.org.au>

Improve debug logging for render modules

Signed-off-by: bones_was_here <bones_was_here@xa.org.au>