Add prefix to VM_Warning indicating which VM it came from

A few messages include this but many don't, and in future there will be
less functions with SV or CL in their name.

Signed-off-by: bones_was_here <bones_was_here@xonotic.au>

droptofloor(): add/improve warnings for badly placed entities

In the past, sv_gameplayfix_droptofloorstartsolid and
sv_gameplayfix_droptofloorstartsolid_nudgetocorrect were enabled by
default when playing Quake, which seems to have led to some maps
depending on them.

These need to be off by default in Quake to avoid gameplay changes,
but we can at least warn people about map entity issues.

See: 34e819a626f6a7ff2ad190a8e7d42e38ca8cef0e

Signed-off-by: bones_was_here <bones_was_here@xonotic.au>

NudgeOutOfSolid: fix "random" failures on slightly inclined planes

History:
This epsilon value was first added to the nudge distance in
31e7715cffcebfd400b8473f3b2d3dc80937fc5a
and was replaced with bbox expansion in
25c09ca585e81bf9eb236a339ae5dcd64f63b679

With the expansion approach we need to compare to separation to make
"good location" detection reliable, partly to avoid float precision
problems, partly to avoid compatibility problems with normal TraceBox.
For example: we drop an entity to floor successfully with TraceBox, but
then NudgeOutOfSolid decides it's in solid.

Also updated the startsolid conditions to suit the 2-pass approach.

Signed-off-by: bones_was_here <bones_was_here@xonotic.au>

NudgeOutOfSolid: add a wasn't-stuck result

It can be handy for calling code to know if the entity was initially
stuck (mainly for warnings).

Signed-off-by: bones_was_here <bones_was_here@xonotic.au>

Move SV_NudgeOutOfSolid() into a common namespace and unit

Signed-off-by: bones_was_here <bones_was_here@xonotic.au>

Disambiguate WriteDest warning

Signed-off-by: bones_was_here <bones_was_here@xonotic.au>

Clarify behaviour of random() builtin

Declare DP_QC_WHICHPACK in menudefs.qc and csprogsdefs.qc

It was only declared in dpextensions.qc

README.md: add badge for #darkplaces:matrix.org chat link

Signed-off-by: bones_was_here <bones_was_here@xonotic.au>

Improve x86 detection to fix compiler errors on other architectures

Also some related minor makefile cleanup.

Closes https://gitlab.com/xonotic/darkplaces/-/issues/382

See also: 1244b3ab0853e8738c8f5e5b617e8d8f25d4eca4

Signed-off-by: bones_was_here <bones_was_here@xonotic.au>

Merge branch 'kiwixz/macos_compile' into 'master'

Fix compilation on macOS

See merge request xonotic/darkplaces!140

Fixes https://github.com/DarkPlacesEngine/darkplaces/issues/79

Fix compilation on macOS

It has been broken since 2a97ec851bd607510e33148335fc61d51e7138cf.

Signed-off-by: kiwixz <kiwixz@outlook.com>

Update compiler options, fixing obscure bug

Added -mno-avx to avoid QC bugs on (at least) haswell and skylake targets.

Removed -fno-signaling-nans as clang doesn't support it and spams warns,
and in GCC it's the default.

Removed -fno-rounding-math as this is also the default.

fs: Use unsigned short for filename size

Also remove namesize < 0 check as this is no longer possible

fs: Use unsigned short for extra field and file comment lengths

Fix DP_QC_FINDCHAIN_TOFIELD errors

Signed-off-by: bones_was_here <bones_was_here@xonotic.au>

Implement extension DP_QC_FINDBOX

Returns a chain of entities that are touching a box (a simpler findradius);
supports DP_QC_FINDCHAIN_TOFIELD

Implements https://gitlab.com/xonotic/darkplaces/-/issues/373

Signed-off-by: bones_was_here <bones_was_here@xonotic.au>

Fix COLLISIONPARANOID build errors and warns

Signed-off-by: bones_was_here <bones_was_here@xonotic.au>

Add cvars that disable linking of SOLID_NOT entities: [cl|sv]_areagrid_link_SOLID_NOT

This also removes the partial solution added in b1d6f1dfb96bedba50fbe394ca3f0c710f99381b https://gitlab.com/xonotic/darkplaces/-/merge_requests/78

Signed-off-by: bones_was_here <bones_was_here@xonotic.au>

Optimise bindable unicode codepoint range

This improves FPS on (specifically) the Xonotic key bindings menu
screen.

Signed-off-by: bones_was_here <bones_was_here@xonotic.au>

Merge PR 'Fixed two keyboard bugs'

See https://github.com/DarkPlacesEngine/darkplaces/pull/68

Commits:
5ca6703d5f57ebe18c1fc1a97c646ba468c49442
871cfdae9e48274eacb720e2423b9d8b3818bee9

Fixes https://gitlab.com/xonotic/darkplaces/-/issues/46
Fixes https://gitlab.com/xonotic/darkplaces/-/issues/51
Fixes https://gitlab.com/xonotic/darkplaces/-/issues/60
Fixes https://gitlab.com/xonotic/darkplaces/-/issues/147

Signed-off-by: bones_was_here <bones_was_here@xonotic.au>

Add cvar sv_legacy_bbox_expand for disabling Quake entity bbox expansion

This avoids obscure bugs and awkward workarounds especially with CSQC player prediction.

Signed-off-by: bones_was_here <bones_was_here@xonotic.au>

Fix GCC 12 warns: comparison will always evaluate as true

Fixes https://github.com/DarkPlacesEngine/darkplaces/issues/55

Signed-off-by: bones_was_here <bones_was_here@xonotic.au>

Simplify VID_SetMouse() calling logic

Signed-off-by: bones_was_here <bones_was_here@xonotic.au>

refine edge cases handling to keynums/keystrings,
use the new constant `TINYSTR_LEN` in place of `sizeof(tinystr)` leftovers

Signed-off-by: NaitLee <naitli@foxmail.com>

Fixed two keyboard bugs:
Fixed inability to bind non-ascii keys;
Fixed only the first character being input when using an Input Method

Signed-off-by: NaitLee <naitli@foxmail.com>

Release the mouse during loading screen

Signed-off-by: kiwixz <kiwixz@outlook.com>

Merge MR 'Reinstate the ability to override engine commands with QC commands'

See https://gitlab.com/xonotic/darkplaces/-/merge_requests/136

Fixes https://github.com/DarkPlacesEngine/darkplaces/issues/64

Signed-off-by: bones_was_here <bones_was_here@xonotic.au>

Combine NetConn_UpdateSockets_Client() and NetConn_cl_netport_Callback()

These blocks must run together to avoid bug https://gitlab.com/xonotic/darkplaces/-/issues/376
Also, after a057e4757b55a90cbcdc287b3fdf54ccc2682315 the only
NetConn_UpdateSockets_Client() call site was in NetConn_cl_netport_Callback().

Signed-off-by: bones_was_here <bones_was_here@xonotic.au>

Remove the Xonotic +showscores kludge

Fixes https://github.com/DarkPlacesEngine/darkplaces/issues/64

See also: https://gitlab.com/xonotic/xonotic-data.pk3dir/-/merge_requests/1128
and 3912e78a6047f2c45b3ff4967df7a68ad4e1b994

Signed-off-by: bones_was_here <bones_was_here@xonotic.au>

Reimplement the ability to override engine commands with QC commands

This was working in div0-stable and was removed in 46acef5491629d06eddb8e78ed01e50b175d2bd8

Due to previous improvements by LH & Cloudwalk, the behaviour is now better:
the new QC command appears in the console in addition to the engine one,
the new command takes priority and what's going on is clearer.
When the CSQC VM shuts down, the registered command is removed.

Also this time we can has documentation.

Signed-off-by: bones_was_here <bones_was_here@xonotic.au>

Keep sockets opened after first disconnect

Signed-off-by: kiwixz <kiwixz@outlook.com>

Improve client/listen curl transfer speed at low FPS

This is a huge boost for some libcurl versions, eg 7.74 in Debian 11

Fixes https://gitlab.com/xonotic/darkplaces/-/issues/375

Signed-off-by: bones_was_here <bones_was_here@xonotic.au>

Add cvar scr_conheight and make loading progress visible under fullscreen console

Also updates related cvar descriptions and increases default
scr_loadingscreen_maxfps to 20, 10 just looked too janky.

Signed-off-by: bones_was_here <bones_was_here@xonotic.au>

Merge MR 'Refactor loading screen and fix it'

See https://gitlab.com/xonotic/darkplaces/-/merge_requests/135

Signed-off-by: bones_was_here <bones_was_here@xonotic.au>

Refactor loading screen and fix it

Signed-off-by: kiwixz <kiwixz@outlook.com>

Use correct droptofloor distance for each Quake map format

Signed-off-by: bones_was_here <bones_was_here@xonotic.au>

Remove code duplication in messagemodes and commandmode

Signed-off-by: bones_was_here <bones_was_here@xonotic.au>

Disable messagemode and messagemode2 during demo playback

Signed-off-by: bones_was_here <bones_was_here@xonotic.au>

Unload dlcache packs when changing map or disconnecting

Prevents content from the previous server and/or map from interfering with the next

Signed-off-by: bones_was_here <bones_was_here@xonotic.au>

Minor sv_cullentities refactoring

Improve reliability and documentation of portal camera eyes

Not all traces will succeed so we need to add the eye if a trace
succeeded within some recent time period, instead of only adding it when
a trace succeeded in the current frame.

Fixes https://gitlab.com/xonotic/darkplaces/-/issues/207
Fixes https://gitlab.com/xonotic/xonotic-data.pk3dir/-/issues/1596

Merge MR 'Adding the natural curve mouse acceleration'
https://gitlab.com/xonotic/darkplaces/-/merge_requests/122

branch 'natural_acceleration'

Signed-off-by: bones_was_here <bones_was_here@xonotic.au>

Adding the natural curve mouse acceleration

Signed-off-by: Draena <franparpe@disroot.org>

README.md: add links to CREDITS.md and CONTRIBUTING.md

Signed-off-by: bones_was_here <bones_was_here@xonotic.au>

Fix DEBUGGL warns & checking logic in R_Mesh_CreateFramebufferObject

Signed-off-by: bones_was_here <bones_was_here@xa.org.au>

Improve DEBUGGL

glGetError() must be called in a loop to retrieve and reset
multiple error flags.

Signed-off-by: bones_was_here <bones_was_here@xa.org.au>

glquake.h: fix wrapper #ifndef

Signed-off-by: bones_was_here <bones_was_here@xa.org.au>

Fix GCC 11 warns: r_shadow.c misleading indentation, also remove duplicated code

Signed-off-by: bones_was_here <bones_was_here@xa.org.au>

Fix GCC 11 warns: use uninitialized in R_CanSeeBox

Introduced in 8ab339588b127e88e27bfa08f6eccbf9400b51f9

Signed-off-by: bones_was_here <bones_was_here@xa.org.au>

Fix GCC 11 warns: Mod_INTERQUAKEMODEL_Load misleading indentation

Signed-off-by: bones_was_here <bones_was_here@xa.org.au>

Fix GCC 11 warns: Con_Shutdown misleading indentation

Signed-off-by: bones_was_here <bones_was_here@xa.org.au>

Fix GCC 11 warns: Matrix4x4_FromArrayFloatGL overread

Signed-off-by: bones_was_here <bones_was_here@xa.org.au>

Fix GCC 11 warns: Matrix4x4_ToArray12FloatGL overflow

Signed-off-by: bones_was_here <bones_was_here@xa.org.au>

Fix GCC 11 warns: Matrix4x4_FromArrayDoubleD3D overread

Signed-off-by: bones_was_here <bones_was_here@xa.org.au>

Fix GCC 11 warns: mismatched prototype args

Signed-off-by: bones_was_here <bones_was_here@xa.org.au>

Check macOS version < 12 to use old function name

Fixes building on macOS < 12

Optimize VectorNormalize macros by not doing the sqrt on 0 length, this also means it should be more friendly to the CPU intrinsics for 1/sqrt in a single instruction

Resolved .gitignore conflict

Update SDL2.nuget package to 2.0.22, add some more things to .gitignore.

Added convex.[ch] to compute brush shapes from point clouds for use in experimental visibility code I'm tinkering with

Add CONTRIBUTING.md for contributing guidelines

Signed-off-by: Cloudwalk <cloudwalk@icculus.org>

Merge PR 'Curl improvements'

Curl versions older than 7.57.0 (found on Debian Stretch and older) do
not implicitly initialize openssl, which leads https requests to fail.

In the course of debugging this issue verbose curl requests were needed,
so that has also been added as a cvar.

https://github.com/DarkPlacesEngine/darkplaces/pull/36

commits: ceaa16c78a1f43165206566d4f9c872664f7e680
1a711173535d4b5f4364b66177745aab165330d8

Signed-off-by: bones_was_here <bones_was_here@xa.org.au>

Merge PR 'Add a third masterextra and default it to dpm.dpmaster.org'

dpm.dpmaster.org has been serving as a xonotic master (as
dpm4.xonotic.xyz and dpm6.xonotic.xyz) for three months now, and I offer
it here in hopes it's of use.

https://github.com/DarkPlacesEngine/darkplaces/pull/33

commits: 8289ce6a72d06635b6667d7e6e80ee0890ea7c09

Signed-off-by: bones_was_here <bones_was_here@xa.org.au>

Explicitly initialize openssl for older curl versions

Signed-off-by: Gary Moon <gary@garymoon.net>

Adding developer_curl to print verbose curl output

Signed-off-by: Gary Moon <gary@garymoon.net>

Add a third masterextra and default it to dpm.dpmaster.org

dpm.dpmaster.org has been serving as a xonotic master (as
dpm4.xonotic.xyz and dpm6.xonotic.xyz) for three months now, and I offer
it here in hopes it's of use.

Signed-off-by: Gary Moon <gary@garymoon.net>

Add cvar snd_cdautopause: optional CD track pause during game pause

Previously it was mandatory and if not desired, had to be hacked around
with stuffcmd.

Also fixes:
- the CD track always being resumed when resuming from game pause,
even when muted, Ref: CDAudio_SetVolume()
- bgmvolume < 0 not pausing the CD track

Signed-off-by: bones_was_here <bones_was_here@xa.org.au>

Start render module CL_MeshEntities immediately prior to Models

Fixes https://gitlab.com/xonotic/darkplaces/-/issues/366

Starting CL_MeshEntities any later can cause the bug during r_restart.

ca03733fba98709e25d9a02882ac947f4144af6a effectively added dependency
of the Models module on the CL_MeshEntities module,
at least in certain situations where starting the Models module
results in calls to Draw_CachePic() and DrawQ_*()
which trigger the bug when they call Mod_Mesh_GetTexture().

Signed-off-by: bones_was_here <bones_was_here@xa.org.au>

Improve debug logging for render modules

Signed-off-by: bones_was_here <bones_was_here@xa.org.au>

README, sdl, sys, makefile: Bring up macOS support

* Fixed up the makefile to support modern macOS builds
* Fixed up sys.h to detect macOS properly
* Added macOS build instructions. Dependencies are now fetched using Homebrew.
* Remove now-unneeded SDLMain.h and .m files

Signed-off-by: Cloudwalk <cloudwalk@icculus.org>

README: Add link to Matrix space

Signed-off-by: bones_was_here <bones_was_here@xa.org.au>

 README: Remove Discord invite link. The Discord server is now deprecated

I'm unable to sustain the DarkPlaces engine community on Discord. They have
falsely disabled my main account and now my second account, this time
without an email explaining the reason. I have a 3rd account that is still
active. They have not responded to my emails asking for them to review
the ban of my main account and they have the gall to nuke my second
account as well.

They are flooded with support tickets likely because it is incredibly easier
to hijack a Discord account than any other account due to the simple fact
that Discord does NOT require email verification to change passwords. God
only knows what other horrors lie beneath that Eldritch abomination of
duct-taped JavaScript.

I was not banned from Discord as I was able to create the third account using
the same IP address. They ban IPs if you're banned from Discord. I can no
longer, in good conscience, give this shit, incompetent, bullshit company
a single neuron of mindshare going forward. Other arrangements for a community
hangout are to be determined but are not available at this time. The IRC,
obviously, remains available.

Until they get their shit together (if they do), FUCK Discord and FUCK
everything they stand for.

Signed-off-by: Cloudwalk <cloudwalk@icculus.org>

Merge PR 'sv_gameplayfix_stepmultipletimes 1: Prevent players moving too far/fast when stepping up a staircase'

After the player made some horizontal progress, and before stepping up, it's necessary to recalculate the remaining time and distance for the move. Previously the step up made the player travel (up to) nearly the move's full distance, again.

https://github.com/DarkPlacesEngine/darkplaces/pull/10

branch: bones_was_here/stepup_distance
commits: 365e221966b15c24c6e2f4cbb6e619b0db443ebf

Signed-off-by: bones_was_here <bones_was_here@xa.org.au>

Merge PR 'sv_gameplayfix_stepmultipletimes 1: Make stepping up while jumping reliable'

When the player is hard up against a solid surface trying to climb up, they are blocked from gaining any significant speed by the solid, so the distance they could potentially move into the solid at that speed can be well under 0.03125 units, causing the step up to fail.

The same can happen when the player is stepping up with less than 0.03125 units of distance left on their move, causing them to stop dead when climbing stairs at speed with sv_gameplayfix_stepmultipletimes 1.

https://github.com/DarkPlacesEngine/darkplaces/pull/11

branch: bones_was_here/stepup_reliability
commits: 4c6cb7882855468365644ac65b6eb86a3e82a812

Signed-off-by: bones_was_here <bones_was_here@xa.org.au>

Merge MR 'Set groundentity when sv_gameplayfix_downtracesupportsongroundflag detects a floor'

Fixes movers not carrying players who walk onto them with no z
velocity, when sv_gameplayfix_nogravityonground is enabled

https://github.com/DarkPlacesEngine/darkplaces/pull/23

branch: bones_was_here/walking_groundentity_fix
commits: 7ea07939bef0cbe85c54d9f68cb924198b0b1f64

Signed-off-by: bones_was_here <bones_was_here@xa.org.au>

Merge MR 'Make trace entity culling optional for spectators'

https://gitlab.com/xonotic/darkplaces/-/merge_requests/115
https://github.com/DarkPlacesEngine/darkplaces/pull/13

branch: bones_was_here/trace
commits: 2c1140a494598d75a12c01f82d7c9accff974fbb

Signed-off-by: bones_was_here <bones_was_here@xa.org.au>

Doxygen: more tweaks

Signed-off-by: bones_was_here <bones_was_here@xa.org.au>

Doxygen: disable CALL_GRAPH and CALLER_GRAPH

Many of these graphs are too huge and complex to be readable,
and they use > 8GiB on disk and a lot of CPU time to generate.
They can be enabled for specific funcs if required.

Signed-off-by: bones_was_here <bones_was_here@xa.org.au>

.gitignore: add kdevelop files

Signed-off-by: bones_was_here <bones_was_here@xa.org.au>

COPYING: Remove formfeed characters that don't serve any purpose but make vscode annoyed

Set groundentity when sv_gameplayfix_downtracesupportsongroundflag detects a floor

Fixes movers not carrying players who walk onto them with no z
velocity, when sv_gameplayfix_nogravityonground is enabled

Fixes https://github.com/DarkPlacesEngine/darkplaces/issues/22
sv_gameplayfix_nogravityonground 1 prevents movers from detecting players #22

Signed-off-by: bones_was_here <bones_was_here@xa.org.au>

Prevent players moving too far when stepping up

After the player made some horizontal progress, and before stepping up, it's necessary to recalculate the remaining time and distance for the move. Previously the step up made the player travel (up to) nearly the move's full distance, again.

Fixes https://github.com/DarkPlacesEngine/darkplaces/issues/9
sv_gameplayfix_stepmultipletimes 1: players travel further than their velocity should allow #9

Signed-off-by: bones_was_here <bones_was_here@xa.org.au>

Make stepping up while jumping reliable

When the player is hard up against a solid surface trying to climb up, they are blocked from gaining any significant speed by the solid, so the distance they could potentially move into the solid at that speed can be well under 0.03125 units, causing the step up to fail.

The same can happen when the player is stepping up with less than 0.03125 units of distance left on their move, causing them to stop dead when climbing stairs at speed with sv_gameplayfix_stepmultipletimes 1.

Fixes https://github.com/DarkPlacesEngine/darkplaces/issues/8
Stepping up is unreliable #8

Signed-off-by: bones_was_here <bones_was_here@xa.org.au>

Doxygen: Set DOT_NUM_THREADS to 0, being automatic, disable side bar because its visualization is messy (#21)

* Upgrade doxygen version, add better implementations, sidebar added

More updates from Doxygen enhancing document visualization

* Set DOT_NUM_THREADS to 0, being automatic, disable side bar because its visualization is messy

Set DOT_NUM_THREADS to 0, being automatic, disable side bar because its visualization is messy

Doxygen: configure logo and add link to README

Upgrade doxygen version, add better implementations, sidebar added (#20)

More updates from Doxygen enhancing document visualization

Merge pull request #19 from LegendaryGuard/patch-1: Improving Doxyfile

Improving Doxyfile, adding GENERATE_TREEVIEW and SEARCHENGINE variable features

Improving Doxyfile, adding GENERATE_TREEVIEW and SEARCHENGINE variable features

I would like to propose that there's a Doxygen page in https://xonotic.org/doxygen/darkplaces/, and needs to show a navigation bar and a search engine. Documentation tools need to be improved.

.gitignore: Update to ignore .cache directory created by clangd and build directory for future cmake system

protocol: Fix off-by-one when appending space in Protocol_Names

cmd: Check for empty cbuf when inserting too

Fix an IO exception on exit when using -condebug because FS_Close was trying to log something but the logfile is already closed, now tracks logfile in a local variable so logfile can be set to NULL sooner.

Fix a bug in Cvar_RegisterVirtual which was corrupting memory when adding a second alias to a cvar.

Add packages.config to make nuget work for vs2019

com_list: Require type explicitly. Remove Q_typeof as typeof and decltype are unavailable in MSVC

qdefs: Change ALWAYSINLINE -> ALWAYS_INLINE

qdefs: Check _MSC_VER instead of incorrect MSVC

sv_main: Add campaign cvar. Set 1 if not coop or deathmatch (Quake rerelease compatibility)

common: Move com_game headers to new com_game.h