From: Martin Taibr <taibr.martin@gmail.com>
Date: Mon, 26 Aug 2019 18:48:29 +0000 (+0200)
Subject: comment audio formats
X-Git-Url: https://git.rm.cloudns.org/?a=commitdiff_plain;h=refs%2Fheads%2Fproraide%2Fdarkplaces_issue_145;p=xonotic%2Fdarkplaces.git

comment audio formats
---

diff --git a/snd_sdl.c b/snd_sdl.c
index 6de41d65..d5cca856 100644
--- a/snd_sdl.c
+++ b/snd_sdl.c
@@ -70,6 +70,7 @@ static void Buffer_Callback (void *userdata, Uint8 *stream, int len)
 			memcpy(&stream[PartialLength1], &snd_renderbuffer->ring[0], PartialLength2);
 
 			// As of SDL 2.0 buffer needs to be fully initialized, so fill leftover part with silence
+			// FIXME this is another place that assumes 8bit is always unsigned and others always signed
 			memset(&stream[PartialLength1 + PartialLength2], snd_renderbuffer->format.width == 1 ? 0x80 : 0, len - (PartialLength1 + PartialLength2));
 		}
 		else
@@ -77,6 +78,7 @@ static void Buffer_Callback (void *userdata, Uint8 *stream, int len)
 			memcpy(stream, &snd_renderbuffer->ring[StartOffset * factor], FrameCount * factor);
 
 			// As of SDL 2.0 buffer needs to be fully initialized, so fill leftover part with silence
+			// FIXME this is another place that assumes 8bit is always unsigned and others always signed
 			memset(&stream[FrameCount * factor], snd_renderbuffer->format.width == 1 ? 0x80 : 0, len - (FrameCount * factor));
 		}