From: Wolfgang (Blub) Bumiller <blub@speed.at>
Date: Sun, 11 Nov 2012 18:02:50 +0000 (+0100)
Subject: Fix array-index codegen conditions
X-Git-Tag: 0.1~19^2~24
X-Git-Url: https://git.rm.cloudns.org/?a=commitdiff_plain;h=feec2d74ee83f1bc781d31c547e92498fabe5d51;p=xonotic%2Fgmqcc.git

Fix array-index codegen conditions
---

diff --git a/ast.c b/ast.c
index 4de5443..ac204d3 100644
--- a/ast.c
+++ b/ast.c
@@ -1537,47 +1537,42 @@ bool ast_array_index_codegen(ast_array_index *self, ast_function *func, bool lva
         return false;
     }
 
-    if (!ast_istype(self->index, ast_value)) {
+    arr = (ast_value*)self->array;
+    idx = (ast_value*)self->index;
+
+    if (!ast_istype(self->index, ast_value) || !idx->isconst) {
+        /* Time to use accessor functions */
+        ast_expression_codegen *cgen;
+        ir_value               *iridx, *funval;
+        ir_instr               *call;
+
         if (lvalue) {
-            asterror(ast_ctx(self), "array indexing here needs a compile-time constant");
+            asterror(ast_ctx(self), "(.2) array indexing here needs a compile-time constant");
             return false;
-        } else {
-            /* Time to use accessor functions */
-            ast_expression_codegen *cgen;
-            ir_value               *iridx, *funval;
-            ir_instr               *call;
-
-            if (!arr->getter) {
-                asterror(ast_ctx(self), "value has no getter, don't know how to index it");
-                return false;
-            }
-
-            cgen = self->index->expression.codegen;
-            if (!(*cgen)((ast_expression*)(self->index), func, true, &iridx))
-                return false;
+        }
 
-            cgen = arr->getter->expression.codegen;
-            if (!(*cgen)((ast_expression*)(arr->getter), func, true, &funval))
-                return false;
+        if (!arr->getter) {
+            asterror(ast_ctx(self), "value has no getter, don't know how to index it");
+            return false;
+        }
 
-            call = ir_block_create_call(func->curblock, ast_function_label(func, "fetch"), funval);
-            if (!call)
-                return false;
-            if (!ir_call_param(call, iridx))
-                return false;
+        cgen = self->index->expression.codegen;
+        if (!(*cgen)((ast_expression*)(self->index), func, true, &iridx))
+            return false;
 
-            *out = ir_call_value(call);
-            self->expression.outr = *out;
-            return true;
-        }
-    }
+        cgen = arr->getter->expression.codegen;
+        if (!(*cgen)((ast_expression*)(arr->getter), func, true, &funval))
+            return false;
 
-    arr = (ast_value*)self->array;
-    idx = (ast_value*)self->index;
+        call = ir_block_create_call(func->curblock, ast_function_label(func, "fetch"), funval);
+        if (!call)
+            return false;
+        if (!ir_call_param(call, iridx))
+            return false;
 
-    if (!idx->isconst) {
-        asterror(ast_ctx(self), "(.2) array indexing here needs a compile-time constant");
-        return false;
+        *out = ir_call_value(call);
+        self->expression.outr = *out;
+        return true;
     }
 
     if (idx->expression.vtype == TYPE_FLOAT)