From: terencehill <piuntn@gmail.com>
Date: Sat, 23 Mar 2019 13:56:01 +0000 (+0100)
Subject: Add a dedicated function for shuffleteams code
X-Git-Tag: xonotic-v0.8.5~1404^2~3
X-Git-Url: https://git.rm.cloudns.org/?a=commitdiff_plain;h=fe28ec1479411c11b724b9d2fd2ce3d04332c0dd;p=xonotic%2Fxonotic-data.pk3dir.git

Add a dedicated function for shuffleteams code
---

diff --git a/qcsrc/server/command/sv_cmd.qc b/qcsrc/server/command/sv_cmd.qc
index e8fc1b13f1..d25d963fac 100644
--- a/qcsrc/server/command/sv_cmd.qc
+++ b/qcsrc/server/command/sv_cmd.qc
@@ -1274,50 +1274,55 @@ void GameCommand_setbots(int request, int argc)
 	}
 }
 
-void GameCommand_shuffleteams(int request)
+void shuffleteams()
 {
-	switch (request)
+	if (!teamplay)
 	{
-		case CMD_REQUEST_COMMAND:
-		{
-			if (!teamplay)
-			{
-				LOG_INFO("Can't shuffle teams when currently not playing a team game.");
-				return;
-			}
+		LOG_INFO("Can't shuffle teams when currently not playing a team game.");
+		return;
+	}
 
-			FOREACH_CLIENT(IS_PLAYER(it) || it.caplayer, {
-				if (Player_HasRealForcedTeam(it)) {
-					// we could theoretically assign forced players to their teams
-					// and shuffle the rest to fill the empty spots but in practise
-					// either all players or none are gonna have forced teams
-					LOG_INFO("Can't shuffle teams because at least one player has a forced team.");
-					return;
-				}
-			});
+	FOREACH_CLIENT(IS_PLAYER(it) || it.caplayer, {
+		if (Player_HasRealForcedTeam(it)) {
+			// we could theoretically assign forced players to their teams
+			// and shuffle the rest to fill the empty spots but in practise
+			// either all players or none are gonna have forced teams
+			LOG_INFO("Can't shuffle teams because at least one player has a forced team.");
+			return;
+		}
+	});
 
-			int number_of_teams = 0;
-			entity balance = TeamBalance_CheckAllowedTeams(NULL);
-			for (int i = 1; i <= NUM_TEAMS; ++i)
-			{
-				if (TeamBalance_IsTeamAllowed(balance, i))
-				{
-					number_of_teams = max(i, number_of_teams);
-				}
-			}
-			TeamBalance_Destroy(balance);
+	int number_of_teams = 0;
+	entity balance = TeamBalance_CheckAllowedTeams(NULL);
+	for (int i = 1; i <= NUM_TEAMS; ++i)
+	{
+		if (TeamBalance_IsTeamAllowed(balance, i))
+		{
+			number_of_teams = max(i, number_of_teams);
+		}
+	}
+	TeamBalance_Destroy(balance);
 
-			int team_index = 0;
-			FOREACH_CLIENT_RANDOM(IS_PLAYER(it) || it.caplayer, {
-				int target_team_index = team_index + 1;
-				if (Entity_GetTeamIndex(it) != target_team_index)
-				{
-					MoveToTeam(it, target_team_index, 6);
-				}
-				team_index = (team_index + 1) % number_of_teams;
-			});
+	int team_index = 0;
+	FOREACH_CLIENT_RANDOM(IS_PLAYER(it) || it.caplayer, {
+		int target_team_index = team_index + 1;
+		if (Entity_GetTeamIndex(it) != target_team_index)
+		{
+			MoveToTeam(it, target_team_index, 6);
+		}
+		team_index = (team_index + 1) % number_of_teams;
+	});
+
+	bprint("Successfully shuffled the players around randomly.\n");
+}
 
-			bprint("Successfully shuffled the players around randomly.\n");
+void GameCommand_shuffleteams(int request)
+{
+	switch (request)
+	{
+		case CMD_REQUEST_COMMAND:
+		{
+			shuffleteams();
 			return;
 		}