From: Dale Weiler <killfieldengine@gmail.com>
Date: Fri, 28 Dec 2012 12:36:15 +0000 (+0000)
Subject: Fix another warning
X-Git-Tag: before-library~455
X-Git-Url: https://git.rm.cloudns.org/?a=commitdiff_plain;h=e4b8df2dc69f8debfcb7ab43a246caf859a2c66a;p=xonotic%2Fgmqcc.git

Fix another warning
---

diff --git a/splint.sh b/splint.sh
index 8408918..0347bc4 100755
--- a/splint.sh
+++ b/splint.sh
@@ -64,7 +64,6 @@ FLAGS_MAYBE="\
 # remove one flag from here at a time while fixing the code so that
 FLAGS_TOFIX="\
     -boolcompare         \
-    -unreachable         \
     -incondefs           \
     -initallelements     \
     -macroredef          \
diff --git a/test.c b/test.c
index 1111c37..5756d45 100644
--- a/test.c
+++ b/test.c
@@ -127,23 +127,6 @@ FILE ** task_popen(const char *command, const char *mode) {
         goto task_popen_error_3;
     }
 
-    /*
-     * clang is stupid, it doesn't understand that yes, this code
-     * is actually reachable.
-     */
-#   ifdef __clang__
-#       pragma clang diagnostic push
-#       pragma clang diagnostic ignored "-Wunreachable-code"
-#   endif
-    if (argv)
-        vec_free(argv);
-
-#   ifdef __clang__
-#    pragma clang diagnostic pop
-#   endif
-
-    return data->handles;
-
 task_popen_error_3: close(errhandle[0]), close(errhandle[1]);
 task_popen_error_2: close(outhandle[0]), close(outhandle[1]);
 task_popen_error_1: close(inhandle [0]), close(inhandle [1]);