From: Dale Weiler <killfieldengine@gmail.com>
Date: Sun, 30 Dec 2012 11:01:45 +0000 (+0000)
Subject: Fix evaluation order bug
X-Git-Tag: before-library~422
X-Git-Url: https://git.rm.cloudns.org/?a=commitdiff_plain;h=d750d17be59638a87883352c18b5ffb97f3e2e60;p=xonotic%2Fgmqcc.git

Fix evaluation order bug
---

diff --git a/exec.c b/exec.c
index 2957d4c..1d6d182 100644
--- a/exec.c
+++ b/exec.c
@@ -475,7 +475,8 @@ static qcint prog_enterfunction(qc_program *prog, prog_section_function *func)
     st.function = func;
 
     if (prog->xflags & VMXF_TRACE) {
-        vec_push(prog->function_stack, prog_getstring(prog, func->name));
+        const char *str = prog_getstring(prog, func->name);
+        vec_push(prog->function_stack, str);
     }
 
 #ifdef QCVM_BACKUP_STRATEGY_CALLER_VARS
diff --git a/splint.sh b/splint.sh
index 0aa2131..ecca177 100755
--- a/splint.sh
+++ b/splint.sh
@@ -63,8 +63,7 @@ FLAGS_MAYBE="\
 #these don't need to be here to onhibit the warning
 # remove one flag from here at a time while fixing the code so that
 FLAGS_TOFIX="\
-    -castfcnptr          \
-    -evalorder"
+    -castfcnptr"
 
 
 splint $FLAGS_STUPID $FLAGS_MAYBE $FLAGS_TOFIX $FLAGS_OTHERS *.c *.h