From: Martin Taibr <taibr.martin@gmail.com>
Date: Sun, 29 Sep 2019 09:55:19 +0000 (+0200)
Subject: better explain -O3 in compilation units test
X-Git-Tag: xonotic-v0.8.5~1256
X-Git-Url: https://git.rm.cloudns.org/?a=commitdiff_plain;h=b3f597009e59745b4c738f647069f763eef64173;p=xonotic%2Fxonotic-data.pk3dir.git

better explain -O3 in compilation units test
---

diff --git a/qcsrc/tools/compilationunits.sh b/qcsrc/tools/compilationunits.sh
index 68f2eb9d5..7a7ff17b6 100755
--- a/qcsrc/tools/compilationunits.sh
+++ b/qcsrc/tools/compilationunits.sh
@@ -38,7 +38,11 @@ QCCDEFS="${QCCDEFS[@]}"
 
 declare -a QCCFLAGS=(
     -std=gmqcc
-    -O3 # optimization to accept variable initialization inside `if (1)` blocks and avoid warnings
+    # Without -O3, GMQCC thinks some variables are used uninitialized if the initialization is done inside an `if (1)` block
+    # (which is created by e.g. BEGIN_MACRO) which would cause the compilation units test to fail.
+    # There doesn't appear to be any measurable increase in compile time
+    # and it allows us to get rid of some explicit initializations which are just useless noise.
+    -O3
     -Wall -Werror
     -futf8
     -freturn-assignments