From: havoc <havoc@d7cf8633-e32d-0410-b094-e92efae38249>
Date: Thu, 16 Jun 2005 22:43:37 +0000 (+0000)
Subject: replace control characters (such as newline) with _ in savegame comments, this fixes... 
X-Git-Tag: xonotic-v0.1.0preview~4740
X-Git-Url: https://git.rm.cloudns.org/?a=commitdiff_plain;h=9f3549cd70f8ba966afc2fdf9da239ca2a444b2e;p=xonotic%2Fdarkplaces.git

replace control characters (such as newline) with _ in savegame comments, this fixes loading savegames in 'dungeon.bsp' of The Ascension of Vigil, and probably some other maps that use newlines in their titles (nasty)


git-svn-id: svn://svn.icculus.org/twilight/trunk/darkplaces@5443 d7cf8633-e32d-0410-b094-e92efae38249
---

diff --git a/host_cmd.c b/host_cmd.c
index fae72a98..59eaee05 100644
--- a/host_cmd.c
+++ b/host_cmd.c
@@ -435,12 +435,14 @@ void Host_SavegameComment (char *text)
 
 	for (i=0 ; i<SAVEGAME_COMMENT_LENGTH ; i++)
 		text[i] = ' ';
-	memcpy (text, cl.levelname, strlen(cl.levelname));
+	// LordHavoc: added min() to prevent overflow
+	memcpy (text, cl.levelname, min(strlen(cl.levelname), SAVEGAME_COMMENT_LENGTH));
 	sprintf (kills,"kills:%3i/%3i", cl.stats[STAT_MONSTERS], cl.stats[STAT_TOTALMONSTERS]);
 	memcpy (text+22, kills, strlen(kills));
-// convert space to _ to make stdio happy
+	// convert space to _ to make stdio happy
+	// LordHavoc: convert control characters to _ as well
 	for (i=0 ; i<SAVEGAME_COMMENT_LENGTH ; i++)
-		if (text[i] == ' ')
+		if (text[i] <= ' ')
 			text[i] = '_';
 	text[SAVEGAME_COMMENT_LENGTH] = '\0';
 }