From: Dale Weiler Date: Wed, 28 Aug 2013 07:40:35 +0000 (-0400) Subject: Handle return status from compiler, this fixes false positivies in the testsuite... X-Git-Tag: 0.3.5~131 X-Git-Url: https://git.rm.cloudns.org/?a=commitdiff_plain;h=8aaa26842359012f3dcd1ee5263f411feea65275;p=xonotic%2Fgmqcc.git Handle return status from compiler, this fixes false positivies in the testsuite when the compiler segfaults and the testsuite still reports succeeded, now it won't hopefully. --- diff --git a/test.c b/test.c index 6e6aa0a..ed3e56d 100644 --- a/test.c +++ b/test.c @@ -923,7 +923,6 @@ static void task_destroy(void) { * Close any open handles to files or processes here. It's mighty * annoying to have to do all this cleanup work. */ - if (task_tasks[i].runhandles) task_pclose(task_tasks[i].runhandles); if (task_tasks[i].stdoutlog) fs_file_close (task_tasks[i].stdoutlog); if (task_tasks[i].stderrlog) fs_file_close (task_tasks[i].stderrlog); @@ -1060,7 +1059,6 @@ static bool task_trymatch(size_t i, char ***line) { } } - /* * We need to ignore null lines for when -pp is used (preprocessor), since * the preprocessor is likely to create empty newlines in certain macro @@ -1199,6 +1197,18 @@ static size_t task_schedualize(size_t *pad) { continue; } + if (task_pclose(task_tasks[i].runhandles) != EXIT_SUCCESS && strcmp(task_tasks[i].tmpl->proceduretype, "-fail")) { + con_out("failure: `%s` %*s %*s\n", + task_tasks[i].tmpl->description, + (pad[0] + pad[1] - strlen(task_tasks[i].tmpl->description)) + (strlen(task_tasks[i].tmpl->rulesfile) - pad[1]), + task_tasks[i].tmpl->rulesfile, + (pad[1] + pad[2] - strlen(task_tasks[i].tmpl->rulesfile)) + (strlen("(compiler didn't return exit success)") - pad[2]), + "(compiler didn't return exit success)" + ); + failed++; + continue; + } + if (!execute) { con_out("succeeded: `%s` %*s %*s\n", task_tasks[i].tmpl->description,