From: Rudolf Polzer <divverent@xonotic.org>
Date: Wed, 12 Aug 2015 23:48:44 +0000 (+0200)
Subject: Add an explanation, resolving a FIXME.
X-Git-Tag: xonotic-v0.8.1~1^2~1
X-Git-Url: https://git.rm.cloudns.org/?a=commitdiff_plain;h=5670fc6a49f5fbe6f4d770ed63b2851884b68aa0;p=xonotic%2Fxonotic-data.pk3dir.git

Add an explanation, resolving a FIXME.
---

diff --git a/qcsrc/common/mapinfo.qc b/qcsrc/common/mapinfo.qc
index 55165a12c..3ef27e42a 100644
--- a/qcsrc/common/mapinfo.qc
+++ b/qcsrc/common/mapinfo.qc
@@ -1166,7 +1166,13 @@ float MapInfo_Get_ByName_NoFallbacks(string pFilename, int pAllowGenerate, int p
 		else if(t == "cdtrack")
 		{
 			t = car(s); s = cdr(s);
-			if(pGametypeToSet) // FIXME is this check right here?
+			// We do this only if pGametypeToSet even though this
+			// content is theoretically game type independent,
+			// because MapInfo_Map_clientstuff contains otherwise
+			// game type dependent stuff. That way this value stays
+			// empty when not setting a game type to not set any
+			// false expectations.
+			if(pGametypeToSet)
 			{
 				if (!cvar_value_issafe(t))
 					print("Map ", pFilename, " contains a potentially harmful cdtrack, ignored\n");