From: Mattia Basaglia <mattia.basaglia@gmail.com>
Date: Tue, 21 Jul 2015 14:26:18 +0000 (+0200)
Subject: Fix a horrible bug in q3map2
X-Git-Tag: xonotic-v0.8.1~1^2~1^2
X-Git-Url: https://git.rm.cloudns.org/?a=commitdiff_plain;h=2bbbfad1bcc689228c5dcc3fc40ec84dd81b0772;p=xonotic%2Fnetradiant.git

Fix a horrible bug in q3map2

This function passed a int* instead of a void** causing local variables to be overwritten,
which in turn caused the program to crash.
---

diff --git a/tools/quake3/common/threads.c b/tools/quake3/common/threads.c
index 4d44bf36..04946dd2 100644
--- a/tools/quake3/common/threads.c
+++ b/tools/quake3/common/threads.c
@@ -538,7 +538,7 @@ void RunThreadsOn( int workcnt, qboolean showpacifier, void ( *func )( int ) ){
 	size_t stacksize;
 
 	int start, end;
-	int i = 0, status = 0;
+	int i = 0;
 
 	start     = I_FloatTime();
 	pacifier  = showpacifier;
@@ -582,7 +582,7 @@ void RunThreadsOn( int workcnt, qboolean showpacifier, void ( *func )( int ) ){
 		}
 		for ( i = 0 ; i < numthreads ; i++ )
 		{
-			if ( pthread_join( work_threads[i], (void **)&status ) != 0 ) {
+			if ( pthread_join( work_threads[i], NULL ) != 0 ) {
 				Error( "pthread_join failed" );
 			}
 		}