From: Dr. Jaska <drjaska83@gmail.com>
Date: Thu, 25 May 2023 15:12:25 +0000 (+0000)
Subject: Resolve "Setting a weapon's primary damage to 1 causes extremely overpowered push"
X-Git-Tag: xonotic-v0.8.6~68^2
X-Git-Url: https://git.rm.cloudns.org/?a=commitdiff_plain;h=1dcc3a3ada4d042976a12593d8ce63167f96087f;p=xonotic%2Fxonotic-data.pk3dir.git

Resolve "Setting a weapon's primary damage to 1 causes extremely overpowered push"
---

diff --git a/qcsrc/server/damage.qc b/qcsrc/server/damage.qc
index 661f8f945..429d3e262 100644
--- a/qcsrc/server/damage.qc
+++ b/qcsrc/server/damage.qc
@@ -531,11 +531,11 @@ void Freeze(entity targ, float revivespeed, int frozen_type, bool show_waypoint)
 	FOREACH_CLIENT(IS_PLAYER(it),
 	{
 		for(int slot = 0; slot < MAX_WEAPONSLOTS; ++slot)
-	    {
-	    	.entity weaponentity = weaponentities[slot];
-	    	if(it.(weaponentity).hook.aiment == targ)
-	    		RemoveHook(it.(weaponentity).hook);
-	    }
+		{
+			.entity weaponentity = weaponentities[slot];
+			if(it.(weaponentity).hook.aiment == targ)
+				RemoveHook(it.(weaponentity).hook);
+		}
 	});
 
 	// add waypoint
@@ -565,11 +565,11 @@ void Unfreeze(entity targ, bool reset_health)
 	FOREACH_CLIENT(IS_PLAYER(it),
 	{
 		for(int slot = 0; slot < MAX_WEAPONSLOTS; ++slot)
-	    {
-	    	.entity weaponentity = weaponentities[slot];
-	    	if(it.(weaponentity).hook.aiment == targ)
-	    		RemoveHook(it.(weaponentity).hook);
-	    }
+		{
+			.entity weaponentity = weaponentities[slot];
+			if(it.(weaponentity).hook.aiment == targ)
+				RemoveHook(it.(weaponentity).hook);
+		}
 	});
 
 	// remove the ice block
@@ -710,11 +710,11 @@ void Damage(entity targ, entity inflictor, entity attacker, float damage, int de
 		if(IS_PLAYER(targ) && damage > 0 && attacker)
 		{
 			for(int slot = 0; slot < MAX_WEAPONSLOTS; ++slot)
-		    {
-		    	.entity went = weaponentities[slot];
-		    	if(targ.(went).hook && targ.(went).hook.aiment == attacker)
-		    		RemoveHook(targ.(went).hook);
-		    }
+			{
+				.entity went = weaponentities[slot];
+				if(targ.(went).hook && targ.(went).hook.aiment == attacker)
+					RemoveHook(targ.(went).hook);
+			}
 		}
 
 		if(STAT(FROZEN, targ) && !ITEM_DAMAGE_NEEDKILL(deathtype)
@@ -948,7 +948,7 @@ float RadiusDamageForSource (entity inflictor, vector inflictororigin, vector in
 					center = CENTER_OR_VIEWOFS(targ);
 
 					force = normalize(center - myblastorigin);
-					force = force * (finaldmg / coredamage) * forceintensity;
+					force = force * (finaldmg / max(coredamage, edgedamage)) * forceintensity;
 					hitloc = nearest;
 
 					// apply special scaling along the z axis if set
@@ -1018,14 +1018,15 @@ float RadiusDamageForSource (entity inflictor, vector inflictororigin, vector in
 
 						if(autocvar_g_throughfloor_debug)
 							LOG_INFOF(" D=%f F=%f", finaldmg, vlen(force));
+
+						/*if (targ == attacker)
+						{
+							print("hits ", ftos(hits), " / ", ftos(total));
+							print(" finaldmg ", ftos(finaldmg), " force ", ftos(vlen(force)));
+							print(" (", vtos(force), ") (", ftos(a), ")\n");
+						}*/
 					}
 
-					//if (targ == attacker)
-					//{
-					//	print("hits ", ftos(hits), " / ", ftos(total));
-					//	print(" finaldmg ", ftos(finaldmg), " force ", vtos(force));
-					//	print(" (", ftos(a), ")\n");
-					//}
 					if(finaldmg || force)
 					{
 						if(targ.iscreature)
@@ -1050,14 +1051,14 @@ float RadiusDamageForSource (entity inflictor, vector inflictororigin, vector in
 	RadiusDamage_running = 0;
 
 	if(!DEATH_ISSPECIAL(deathtype))
-		accuracy_add(attacker, DEATH_WEAPONOF(deathtype), 0, min(coredamage, stat_damagedone));
+		accuracy_add(attacker, DEATH_WEAPONOF(deathtype), 0, min(max(coredamage, edgedamage), stat_damagedone));
 
 	return total_damage_to_creatures;
 }
 
 float RadiusDamage(entity inflictor, entity attacker, float coredamage, float edgedamage, float rad, entity cantbe, entity mustbe, float forceintensity, int deathtype, .entity weaponentity, entity directhitentity)
 {
-	return RadiusDamageForSource(inflictor, (inflictor.origin + (inflictor.mins + inflictor.maxs) * 0.5), inflictor.velocity, attacker, coredamage, edgedamage, rad, 
+	return RadiusDamageForSource(inflictor, (inflictor.origin + (inflictor.mins + inflictor.maxs) * 0.5), inflictor.velocity, attacker, coredamage, edgedamage, rad,
 									cantbe, mustbe, false, forceintensity, 1, deathtype, weaponentity, directhitentity);
 }