From: Wolfgang Bumiller Date: Tue, 1 May 2012 14:26:25 +0000 (+0200) Subject: Reuse general_instr to shorten create_binop X-Git-Tag: 0.1-rc1~529 X-Git-Url: https://git.rm.cloudns.org/?a=commitdiff_plain;h=0337320054d4dae858ab02304e17c3c287f8b09a;p=xonotic%2Fgmqcc.git Reuse general_instr to shorten create_binop --- diff --git a/ir.c b/ir.c index 20754be..ea3a9ca 100644 --- a/ir.c +++ b/ir.c @@ -982,31 +982,7 @@ ir_value* ir_block_create_binop(ir_block *self, return NULL; } - out = ir_value_out(self->owner, label, store_local, ot); - if (!out) - return NULL; - - in = ir_instr_new(self, opcode); - if (!in) { - ir_value_delete(out); - return NULL; - } - - if (!ir_instr_op(in, 0, out, true) || - !ir_instr_op(in, 1, left, false) || - !ir_instr_op(in, 2, right, false) ) - { - goto on_error; - } - - if (!ir_block_instr_add(self, in)) - goto on_error; - - return out; -on_error: - ir_instr_delete(in); - ir_value_delete(out); - return NULL; + return ir_block_create_general_instr(self, label, opcode, left, right, ot); } ir_value* ir_block_create_general_instr(ir_block *self, const char *label,