]> git.rm.cloudns.org Git - xonotic/xonotic-data.pk3dir.git/commitdiff
Add an explanation, resolving a FIXME.
authorRudolf Polzer <divverent@xonotic.org>
Wed, 12 Aug 2015 23:48:44 +0000 (01:48 +0200)
committerRudolf Polzer <divverent@xonotic.org>
Wed, 12 Aug 2015 23:49:28 +0000 (01:49 +0200)
qcsrc/common/mapinfo.qc

index 55165a12c2efa02fe371e683c49b0a89f18e5d15..3ef27e42a22bb2c08887e955561054d8759fa6c4 100644 (file)
@@ -1166,7 +1166,13 @@ float MapInfo_Get_ByName_NoFallbacks(string pFilename, int pAllowGenerate, int p
                else if(t == "cdtrack")
                {
                        t = car(s); s = cdr(s);
-                       if(pGametypeToSet) // FIXME is this check right here?
+                       // We do this only if pGametypeToSet even though this
+                       // content is theoretically game type independent,
+                       // because MapInfo_Map_clientstuff contains otherwise
+                       // game type dependent stuff. That way this value stays
+                       // empty when not setting a game type to not set any
+                       // false expectations.
+                       if(pGametypeToSet)
                        {
                                if (!cvar_value_issafe(t))
                                        print("Map ", pFilename, " contains a potentially harmful cdtrack, ignored\n");