]> git.rm.cloudns.org Git - xonotic/gmqcc.git/commitdiff
Improper use of a possible negative value.
authorDale Weiler <killfieldengine@gmail.com>
Fri, 21 Jun 2013 23:49:08 +0000 (23:49 +0000)
committerDale Weiler <killfieldengine@gmail.com>
Fri, 21 Jun 2013 23:49:08 +0000 (23:49 +0000)
pak.c

diff --git a/pak.c b/pak.c
index 35e605ca59c5aae11b553ecf91e6900ee4ae9ddf..ee647382da59cac608f009cc43cf0dc6b14157a1 100644 (file)
--- a/pak.c
+++ b/pak.c
@@ -427,8 +427,16 @@ static bool pak_close(pak_file_t *pak) {
      * our directory entries at the end of the file.
      */
     if (pak->insert) {
+        int tell = fs_file_tell(pak->handle);
+        if (tell < 0) {
+            vec_free     (pak->directories);
+            fs_file_close(pak->handle);
+            mem_d        (pak);
+
+            return false;
+        }
         pak->header.dirlen = vec_size(pak->directories) * 64;
-        pak->header.diroff = ftell(pak->handle);
+        pak->header.diroff = tell;
 
         /* patch header */
         fs_file_seek (pak->handle, 0, SEEK_SET);